Refactored watchable_args and build_original_fullpath methods in Rails::Application #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties/lib/rails/application.rb
josevalim
added a commit
that referenced
this pull request
Jan 15, 2012
Refactored watchable_args and build_original_fullpath methods in Rails::Application
| else | ||
| "#{script_name}#{path_info}" | ||
| end | ||
| ["#{env["SCRIPT_NAME"]}#{env["PATH_INFO"]}", env["QUERY_STRING"]].reject(&:blank?).join("?") |
There was a problem hiding this comment.
This is harder to read than previous code
There was a problem hiding this comment.
Ok, would you prefer this instead?
def build_original_fullpath(env)
script_and_path, query_string = "#{env['SCRIPT_NAME']}#{env['PATH_INFO']}", env['QUERY_STRING']
query_string.present? ? "#{script_and_path}?#{query_string}" : script_and_path
endThere was a problem hiding this comment.
Honestly I prefer the original code, it's easier to read and has no excessively large lines of code
There was a problem hiding this comment.
Alright, no worries, reverted in pull request #4731
benjamineskola
added a commit
to alphagov/whitehall
that referenced
this pull request
Mar 28, 2022
This can be reverted once rails/rails#4470 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by line notes on fa1d9a8.